chore: Use larger runners and disable setup-go caching on Windows for CI #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
force-pushed
the
bflad/larger-runners
branch
from
407b03f to
5102576
Compare
Reference: actions/setup-go#495 Previously, it could take up to 10 minutes to download and unarchive the cache on Windows runners.
bflad
changed the title
ryan-timothy-albert
approved these changes
Dec 3, 2024
|
Going to verify the release workflow by merging #1130 right now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: actions/setup-go#495
This improves PR testing from >15 minutes to <5 minutes by using larger runners (in runner group so we can tune them without adjusting workflow configuration) and by disabling setup-go caching on Windows. Previously, it could take up to 10 minutes to download and unarchive the setup-go cache on Windows runners due to an acknowledged issue. While this could potentially introduce transient network issues downloading the Go modules from Google's proxies, those issues are generally pretty rare in my experience. We could alternatively change the module cache environment variables on Windows to point at the second hard drive on the runner, but that seemed more likely to break at some point outside our control. Ideally GitHub will fix the setup-go action and we'll just remove the Windows-specific
cache: falseafter upgrading.