Fix ASM generating invalid references for static methods in interface #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce classes Static calls to interface methods should use InterfaceMethodRefs instead of MethodRefs. Otherwise, newer JVM versions will throw an IncompatibleClassChangeError. See openjdk/jdk@c36295e#diff-2e49825df1451e2d44694826a70e86bf1a511371482e4de50f7ef09c300bd9bbR780 and https://bugs.openjdk.org/browse/JDK-8145148?focusedCommentId=13958798&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13958798 for more details.
StevenArzt
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static calls to interface methods should use InterfaceMethodRefs instead of MethodRefs. Otherwise, newer JVM versions will throw an IncompatibleClassChangeError.
See openjdk/jdk@c36295e#diff-2e49825df1451e2d44694826a70e86bf1a511371482e4de50f7ef09c300bd9bbR780 and https://bugs.openjdk.org/browse/JDK-8145148?focusedCommentId=13958798&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13958798 for more details.