Confusing steps in 1-add-headers.md #246
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps in 1-add-headers.md were a bit confusing regarding the PR process.
Summary
In the instructions to create a pull request, there is only one step saying "Click Create pull request."
But there are two "Create pull request" buttons.
And something that make the process a bit more confusing for the learner is that when you click in the first Create pull request button:
===
===
You go to a page (Wrong page, you would need to click in the second Create pull request button to go to the right one.) that have a "files changed" field, and the file index.md:
===
===
Ok, it is not a tab (in the steps it is saying to click in a tab), but a learner without much experience, would think that it is the right one.
And the index.md present in that page is not editable yet, so, as pointed by hadder94, (in the issues page) when you click in the menu, the option to edit it grayed out.
Changes
So, to solve this, i recommend putting something similar to what i did.
To make it very clear to the learner, that it is necessary to create a PR.
Giving the instructions to interact with the title of the PR and create it, clicking again in the "Create pull request" button:
===
===
Related issues:
#245 (comment)