-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL hacking #3282
base: main
Are you sure you want to change the base?
Add PostgreSQL hacking #3282
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your README file does not seem to conform to Awesome Lint rules. Therefore, you are getting errors in Checks > awesome-lint
. To solve the problem, you need to run the following command in the main directory of your project:
npx awesome-lint
Upon completion of the command, make sure to fix all errors and get the ✔ Linting
message. For more information about Awesome Lint click here.
I've edit the repo conform to awesome-lint, there is one requirement that not satisfied, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no issue with npx awesome-lint https://github.com/pghacking/awesome-postgres-hacking
; it is now ✅ Linting
successfully.
It would be better to add it to the README.md file of the Awesome repository as follows because other projects have added it this way.
- PostgreSQL - Object-relational database.
- Hacking - PostgreSQL hacking resources.
There is also a description of “PostgreSQL hacking resources.” It should not start with the title.
Changed as a subentry. |
Your Description: PostgreSQL hacking resources. Example:
|
A curated list of awesome PostgreSQL hacking resources.
Changed accordingly, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, as far as I can see you have added a pull request review, but no ‘approved’, ‘request changes’ or any comments.
I don't remember I add a pull request review, I just do quote reply. I had re-requested your review after I did some change, I'm not sure if mean that. |
The one you added: You should review at least 2 other open pull requests. Checklist request: You should review at least 2 other open pull requests. I think there has been a slight misunderstanding here. It is not enough to say ‘I have reviewed these PRs’. The checklist expects you to do a detailed review and share any shortcomings or suggestions for improvement. For example, you can look at previous reviews and get inspired. So it would be best if you made a more in-depth evaluation. |
OK, I just reviewed #3283 and #3247 and left a LGTM approve message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the list!
Please note in the guidelines:
Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
In your list, most of the entries have none. Only the books, the first two mailing lists, and the tools have them.
Also, there's an empty section "Parser".
TBH, I think the titles are descriptive enough by themselves.
I just add for entry for parser section. |
https://github.com/pghacking/awesome-postgres-hacking
A curated list of awesome PostgreSQL hacking resources.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
I reviewed Add Red-Teaming LLMs #3247, Add Semantic Commit #3283 and Add "FOSS Alternatives" #3256
Add Name of List
. It should not contain the wordAwesome
.- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.