Added support for changeable SwiftUI .keyboardShortcuts, based on the… #181
Conversation
… work done by @mbenoukaiss Modified RecorderCocoa so that it doesn't show a dialog if we are reassigning one of our own menu items
| // Holds the state of the shortcut, and changes that state when the shortcut changes | ||
| // This causes the related NSMenuItem to also update (yipeee) | ||
| @available(macOS 11.0, *) | ||
| struct KeyboardShortcutView<Content: View>: View { |
There was a problem hiding this comment.
I think the idiomatic way to do this would be to use ViewModifier instead
There was a problem hiding this comment.
Yup - there's a view modifier directly above (which uses KeyboardShortcutView). I'm only using KeyboardShortcutView as a wrapper to store state so that the view/menu changes when the shortcut changes. If this is possible using a viewModifier function, happy to learn about it and adjust.
There was a problem hiding this comment.
No, that's a View extension, not a ViewModifier.
|
|
||
| @ViewBuilder | ||
| var shortcutBody: some View { | ||
| if let shortcut, let keyEquivalent = shortcut.toKeyEquivalent() { |
There was a problem hiding this comment.
You don't need to do if and ruin the view id when it changes. Instead, use https://developer.apple.com/documentation/financekitui/addordertowalletbutton/keyboardshortcut(_:)-883ia#
|
I recommend going over the code and also the pull request diff and look for ways to clean it up, fix typos (in comments too), etc. It's still a bit away from being in a mergable state. |
|
Re the comment about going over code and cleaning up: anything specific? I thought it was clean. |
This adds support for SwiftUI menu items (they now auto update when shortcuts are changed).
Also; it won't throw up a UI when modifying the existing shortcut. The implementation ... isn't great (it relies on comparing the instance points of NSMenuItems), but I can't find any other alternative where I can correctly identify that a SwiftUI generated NSMenuItem is related to a given shortcut.