-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64-bit ARM support #29
Conversation
@Nick-Nuon This can be merged at will. The results are good. |
There is a minor issue, it seems, with UTF-16... investigating. |
@Nick-Nuon Ok. It should be good now. I have also added some new namespaces and a new file ( |
OK cool. Taking a look at it right now. |
Splitting things up should make it easier to extend to AVX2 and AVX-512 without getting confused. :-) |
@Nick-Nuon I think that the project is in really good shape. Lots of tests and good benchmarks. It was 'easy' for me to add ARM support. The only tricky part was the need to switch to .NET9. |
It should help a bit yes :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK it looks good, there was one minor comment that was redundant but I took the liberty to trim it.
Merging
We might need to use .NET 9.0 (which is freely available in preview form).
On an Apple M2 (ARM), we are about 50% faster than the accelerated .NET functions. And twice as fast as the UTF-8 function.
After merging this PR, one needs to install https://dotnet.microsoft.com/en-us/download/dotnet/9.0