Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The scope of the unsafe block can be appropriately reduced #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

The scope of the unsafe block can be appropriately reduced #518

wants to merge 1 commit into from

Conversation

cactter
Copy link

@cactter cactter commented Jul 21, 2022

No description provided.

@s3bk
Copy link
Collaborator

s3bk commented Jul 23, 2022

unsafe blocks encapsulate the code that needs to be correct to ensure soundness.
The value and type of vector are critical here, so reducing the block is (in my opinion) not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cactter @s3bk