Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-style-guide-compliant specs into non_conformant/ #1520

Merged
merged 3 commits into from
Mar 3, 2020

Conversation

Awjin
Copy link
Contributor

@Awjin Awjin commented Feb 28, 2020

This change moves all older specs, except for libsass* specs, into a non_conformant/ directory.

It does not otherwise add or delete directories.

See #1516

@Awjin Awjin requested a review from nex3 February 28, 2020 23:14
@nex3
Copy link
Contributor

nex3 commented Feb 28, 2020

Just a couple nits:

  • It's probably a good idea to include non_conformant/README.md to explain to a casual reader what's up with that directory.

  • I'd name this PR something like "move non-style-guide-compliant specs into non_conformant/", since it doesn't fully create the conformant directories.

@Awjin Awjin changed the title Create style-guide conformant directory structure. Move non-style-guide-compliant specs into non_conformant/ Feb 28, 2020
@Awjin Awjin force-pushed the restructure-directories branch 2 times, most recently from e801ed9 to a425575 Compare February 29, 2020 00:04
@Awjin Awjin force-pushed the restructure-directories branch from a425575 to e4f5af2 Compare February 29, 2020 00:11
spec/non_conformant/README.md Outdated Show resolved Hide resolved
@Awjin Awjin merged commit 1d9f15a into master Mar 3, 2020
@stof
Copy link
Contributor

stof commented Nov 1, 2020

@Awjin by curiosity, why not moving the libsass* folders ? AFAICT, these are also non conformant specs.

@Awjin
Copy link
Contributor Author

Awjin commented Nov 2, 2020

LibSass had a separate workflow for their tests, so I didn't want to touch the LibSass folders in this change. That being said, now that LibSass is deprecated, we will need a path forward for managing those tests.

@Awjin Awjin deleted the restructure-directories branch January 12, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants