add limit_denominator method with tests
#103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I would suggest creating a uniform method/trait to approximate numbers (as I proposed in #100), which should work for both float to rational and rational to rational conversions. |
|
I appreciate that you cited your source, but I'm also uncomfortable with the license implications there. I think language translations do still generally count as derived works. I'm not really sure what we need to do about that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
fractionsmodule in the standard library implements a rational type and provides a really handylimit_denominatormethod. I've implemented it here along with some tests.This PR should address #99 .