Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crater run for tail-expr-drop-order #134537

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dingxiangfei2009
Copy link
Contributor

This is experiment for #134523

@dingxiangfei2009
Copy link
Contributor Author

@bors try

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…-run, r=<try>

Crater run for `tail-expr-drop-order`

This is experiment for rust-lang#134523
@bors
Copy link
Contributor

bors commented Dec 19, 2024

⌛ Trying commit e66ffcd with merge 5b4a9ada7bcc184b8fbfdb1737c76da7202f8186...

@dingxiangfei2009
Copy link
Contributor Author

I would like to propose an experiment for comparative study

@craterbot check cap-lints=allow

I am not sure why we need to cap lints to allow in #132712 but it stays to keep it fair.

@craterbot
Copy link
Collaborator

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#22 exporting to docker image format
#22 sending tarball 28.4s done
#22 DONE 35.5s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
77         backward incompatible drop(_5);
78         goto -> bb21;
79     }

thread '[mir-opt] tests/mir-opt/tail_expr_drop_order_unwind.rs' panicked at src/tools/compiletest/src/runtest/mir_opt.rs:93:21:
Actual MIR output differs from expected MIR output /checkout/tests/mir-opt/tail_expr_drop_order_unwind.method_1.ElaborateDrops.after.panic-unwind.mir


failures:
    [mir-opt] tests/mir-opt/tail_expr_drop_order_unwind.rs

@traviscross traviscross added the L-tail_expr_drop_order Lint: tail_expr_drop_order label Dec 19, 2024
@dingxiangfei2009
Copy link
Contributor Author

I think I am seeing things. Where is this tests/mir-opt/tail_expr_drop_order_unwind.rs test? 😕

@bors
Copy link
Contributor

bors commented Dec 19, 2024

☀️ Try build successful - checks-actions
Build commit: 5b4a9ad (5b4a9ada7bcc184b8fbfdb1737c76da7202f8186)

@lqd
Copy link
Member

lqd commented Dec 20, 2024

I think I am seeing things. Where is this tests/mir-opt/tail_expr_drop_order_unwind.rs test? 😕

https://github.com/rust-lang/rust/blob/master/tests/mir-opt/tail_expr_drop_order_unwind.rs

You likely need to pull from master, the test is quite recent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-tail_expr_drop_order Lint: tail_expr_drop_order S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants