added xtask bin for tests (#715, #712) #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery#712 (maybe?) - reworked book operations in xtask - updated readme for new build command - updated contribution.md for new test commands - fixed missing dictionary - added contributor tests to xtask (`cargo test`, `mdbook serve -o`, `./ci/spellcheck.sh`, `link-checker ./book` (moved to Lychee)) - updated ci .sh files for the new cookbook dir - fixed broken link
AndyGauge
reviewed
Dec 16, 2024
README.md
Outdated
| @@ -20,7 +20,7 @@ If you'd like to read it locally: | |||
| $ git clone https://github.com/rust-lang-nursery/rust-cookbook | |||
| $ cd rust-cookbook | |||
| $ cargo install mdbook --vers "0.4.43" | |||
| $ mdbook serve --open | |||
| $ cargo xtask book build | |||
There was a problem hiding this comment.
I think both of these things should be highlighted in the readme, but this included note should have its own section rather than clobbering the mdbook serve --open operation.
There was a problem hiding this comment.
sure I'll revert the changes and create a separate readme
There was a problem hiding this comment.
is there a reason why the version of the mdbook in the contribution guidelines is different from the readme?
- added version check for mdbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #715 fixes #712
cargo test,mdbook serve -o,./ci/spellcheck.sh,link-checker ./book(moved to Lychee))created xtask single bin and alias instead of a workspace to prevent breaking ci or other stuff
does this fix #712 ?
are the changes form #715 fine?