Skip to content

Commit

Permalink
add v3-node20 versions of artifact actions (#468)
Browse files Browse the repository at this point in the history
Note that this restores the workaround for #442.
  • Loading branch information
rhysd committed Nov 6, 2024
1 parent 7c7c0ce commit 187a0b2
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 2 deletions.
20 changes: 20 additions & 0 deletions popular_actions.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions scripts/generate-popular-actions/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,17 @@ func (g *gen) fetchRemote() (map[string]*actionlint.ActionMetadata, error) {
}
}

// Workaround for #442.
// https://github.com/actions/download-artifact/issues/355
if f.spec == "actions/download-artifact@v3-node20" {
if f.meta.Outputs == nil {
f.meta.Outputs = actionlint.ActionMetadataOutputs{}
}
f.meta.Outputs["download-path"] = &actionlint.ActionMetadataOutput{
Name: "download-path",
}
}

ret[f.spec] = f.meta
}

Expand Down
4 changes: 2 additions & 2 deletions scripts/generate-popular-actions/popular_actions.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
},
{
"slug": "actions/download-artifact",
"tags": ["v1", "v2", "v3", "v4"],
"tags": ["v1", "v2", "v3", "v3-node20", "v4"],
"next": "v5"
},
{
Expand Down Expand Up @@ -149,7 +149,7 @@
},
{
"slug": "actions/upload-artifact",
"tags": ["v1", "v2", "v3", "v4"],
"tags": ["v1", "v2", "v3", "v3-node20", "v4"],
"next": "v5"
},
{
Expand Down

0 comments on commit 187a0b2

Please sign in to comment.