Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup formatter and linter for VSCode #63

Closed
wants to merge 2 commits into from

Conversation

scarf005
Copy link
Contributor

makes it easier to apply xo linter and formatter output on VSCode.

@fregante
Copy link
Member

This is config you can keep locally. If you want to add .vscode to gitignore feel free to do so in the other PR

@fregante fregante closed this Aug 26, 2024
@scarf005
Copy link
Contributor Author

scarf005 commented Aug 26, 2024

i disagree that .vscode should be in .gitignore. rationale being:

  1. majority of users use vscode (73.6%, according to stack overflow survey) as their text editor.
  2. XO extension requires a bit of setup.
  3. due to 1 and 2, it can be argued having the setup would make potential future contributors onboarding the repo easier.
  4. having .vscode in repo does not affect other text editors.

"editor.defaultFormatter": "samverschueren.linter-xo"
},
"editor.codeActionsOnSave": {
"source.fixAll": "always"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user preference. I also use VS Code but don’t run linters auto fix on save.

I’m generally not a fan of storing this config on repos and it’s more likely I’ll switch back to a plain eslint at some point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants