Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: catch invalid cases #60

Closed
wants to merge 1 commit into from
Closed

test: catch invalid cases #60

wants to merge 1 commit into from

Conversation

scarf005
Copy link
Contributor

fixes #59
prevents invalid cases from being skipped

@scarf005
test: use recent API
3ba44d8 
prevents invalid cases from being skipped
@scarf005 scarf005 mentioned this pull request Aug 26, 2024
Merged
fregante
fregante reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I fixed the tests on main.

Feel free to restore the Wiki entry in Korean, maybe the latest version improves its support.

@fregante
Copy link
Member

Oh I saw you opened a dedicated PR: #61

@fregante fregante closed this Aug 26, 2024
@scarf005 scarf005 deleted the fix/vitest branch August 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vitest does not catch invalid cases
2 participants
@scarf005 @fregante