Modal onDismiss support for Android

[bernhardoj]

This PR proposes to add Modal onDismiss support for the Android platform.

A rendered version of the proposal can be read here

[bernhardoj]

For context, we previously had a PR to add the onDismiss support for Android, but it was reverted due to an internal codebase that relies on the event not being fired.

With this proposal, I hope we can discuss how to add the onDismiss support for Android properly.

cc: @cipolleschi

[cortinico]

but it was reverted due to an internal codebase that relies on the event not being fired.

That's correct. I believe we won't be able to easily implement onDismiss for Android as we already have apps out in the wild abusing this lack of implementation. Potentially the best way forward is to create a new onModalDismiss property and deprecate the onDismiss one + with a proper migration path.

Just to set expectation, @cipolleschi will be off for the whole month of March. This RFC can't move forward without a champion from Meta, and I won't be able to take on this work as we're currently already 100% full rolling out 0.74 so we'll have to wait to move this forward, sorry for that.

[bernhardoj]

Potentially the best way forward is to create a new onModalDismiss property and deprecate the onDismiss one + with a proper migration path.

That's a good idea to prevent breaking changes. I was thinking that perhaps we can add an enableDismissAndroid props, but this would just add more platform-specific props.

This RFC can't move forward without a champion from Meta, and I won't be able to take on this work as we're currently already 100% full rolling out 0.74 so we'll have to wait to move this forward, sorry for that.

Sorry, I'm not familiar with the process. Do you mean I need to wait for the other Meta member to lead this RFC or you are the one who will lead it but will wait until the 0.74 release is done?

@cortinico

[cortinico]

Do you mean I need to wait for the other Meta member to lead this RFC or you are the one who will lead it but will wait until the 0.74 release is done?

We'd need to find someone from Meta that is interested in driving this forward. Both @cipolleschi and me are essentially off till mid April. We could resume the work on this front afterwards

[bernhardoj]

I see. Thanks for the clarification.

[shubham1206agra]

@cortinico @cipolleschi Are you back from OOO?
Can we push this proposal now?

[shubham1206agra]

@cortinico @cipolleschi Can you please look into this?

[cortinico]

Left my feedback here.

I'd like also to point out how both @cipolleschi and me are hyperfocused on New Architecture rollout at the moment. This falls out of this domain so we won't be able to drive it in the immediate future (sorry for that but our capacity is extremely limited)

[cortinico]

This is practically a hard blocker for us.

IIRC @cipolleschi already imported a change that was implementing onDismiss on Android, as we had several apps that relied on the 'lack' of Android implementation and started misbehaving.

I believe we won't be able to ship this as it is, but we'll have to:

1. Deprecate onDismiss
2. Introduce a new onModalDismiss event that is fired by both platform

[shubham1206agra]

@bernhardoj Please make changes.