Automated Resyntax fixes #462

resyntax-ci · 2024-12-04T00:32:31Z

Resyntax fixed 20 issues in 5 files.

Keep imports in `require` sorted and grouped by phase, with collections before files.

`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting

Internal definitions are recommended instead of `let` expressions, to reduce nesting.

This `let` expression can be pulled up into a `define` expression.

Using `when` and `unless` is simpler than a conditional with an always-throwing branch.

sorawee · 2024-12-04T00:46:35Z

scribble-doc/scribblings/scribble/class-diagrams.rkt

+        (hbl-append
+         (normal-font "(")
+         (let loop ([args args])
+           (let* ([type (car args)]


This let* could be turned to define, I think?

Agreed. Pretty sure the fix limit is the only thing that stopped Resyntax from addressing it.

I think the fix limit should be somehow less strict so that this stops happening.

Yeah, it keeps coming back up. Filed jackfirth/resyntax#429 to track it.

resyntax-ci bot added 5 commits December 4, 2024 00:32

Fix 5 occurrences of tidy-require

aed7db1

Keep imports in `require` sorted and grouped by phase, with collections before files.

Fix 1 occurrence of if-let-to-cond

5d5dac7

`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting

Fix 12 occurrences of let-to-define

5beca04

Internal definitions are recommended instead of `let` expressions, to reduce nesting.

Fix 1 occurrence of define-let-to-double-define

c65027e

This `let` expression can be pulled up into a `define` expression.

Fix 1 occurrence of always-throwing-if-to-when

893e52f

Using `when` and `unless` is simpler than a conditional with an always-throwing branch.

sorawee reviewed Dec 4, 2024

View reviewed changes

Provide feedback