-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update distributionUrl maven to 3.9.9 #2247
Conversation
Latest 3.9.z is 3.9.9, why moving to 3.9.6? Please run There are other changes, e.g. in scripts. |
I noticed that the latest stable version in the 3.9.x series is actually 3.9.9. Initially, I selected 3.9.6 based on previous discussions indicating that 3.9.6 was acceptable. |
c0d1572
to
21e2889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason for tests to be failing, both daily build and my PR that run full CI are green, either you need to rebase this PR on current main or the failures are related. Please have a look.
21e2889
to
deb9b36
Compare
5435454
to
5522243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks. Many of our Jenkins jobs are using this wrapper, you should probably run them when this gets merged to have a smoke check.
Just a side note, this isn't really helping us in what Maven version we are using here in GH. I just want you to know that. This changes the wrapper, but we don't use it in GH workflows, so you are not achieving QQE-1101 and changes here needs to be tested in jenkins. @jcarranzan please beware, thanks |
Just a note: For GH side 10th of January the maven 3.9.9 should be default on all runners. Source actions/runner-images#11093 |
Summary
This task is related to the maven upgrade to 3.9.9 and I've used the command to do the changes:
mvn wrapper:wrapper -Dmaven=3.9.9
Please select the relevant options.
run tests
phrase in comment)Checklist: