Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distributionUrl maven to 3.9.9 #2247

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Dec 12, 2024

Summary

This task is related to the maven upgrade to 3.9.9 and I've used the command to do the changes:
mvn wrapper:wrapper -Dmaven=3.9.9

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda
Copy link
Member

Latest 3.9.z is 3.9.9, why moving to 3.9.6?

Please run mvn wrapper:wrapper -Dmaven=3.9.9.

There are other changes, e.g. in scripts.

@jcarranzan
Copy link
Contributor Author

Latest 3.9.z is 3.9.9, why moving to 3.9.6?

Please run mvn wrapper:wrapper -Dmaven=3.9.9.

There are other changes, e.g. in scripts.

I noticed that the latest stable version in the 3.9.x series is actually 3.9.9. Initially, I selected 3.9.6 based on previous discussions indicating that 3.9.6 was acceptable.
I’ll proceed with upgrading to 3.9.9 (run mvn wrapper:wrapper -Dmaven=3.9.9) and also update the other MRs I already did related to this in our infrastructure.
Thanks.

@jcarranzan jcarranzan changed the title Update distributionUrl maven to 3.9.6 Update distributionUrl maven to 3.9.9 Dec 13, 2024
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason for tests to be failing, both daily build and my PR that run full CI are green, either you need to rebase this PR on current main or the failures are related. Please have a look.

@jcarranzan jcarranzan marked this pull request as ready for review December 16, 2024 12:01
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. Many of our Jenkins jobs are using this wrapper, you should probably run them when this gets merged to have a smoke check.

@michalvavrik
Copy link
Member

michalvavrik commented Dec 16, 2024

Just a side note, this isn't really helping us in what Maven version we are using here in GH. I just want you to know that. This changes the wrapper, but we don't use it in GH workflows, so you are not achieving QQE-1101 and changes here needs to be tested in jenkins. @jcarranzan please beware, thanks

@michalvavrik michalvavrik merged commit 4c57577 into quarkus-qe:main Dec 16, 2024
14 checks passed
@michalvavrik michalvavrik deleted the upgrade-maven-to-396 branch December 16, 2024 12:23
@jedla97
Copy link
Member

jedla97 commented Dec 16, 2024

Just a note: For GH side 10th of January the maven 3.9.9 should be default on all runners. Source actions/runner-images#11093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants