Stop using Enzyme #151
Merged
Stop using Enzyme #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSReds
pushed a commit
to balena-io-modules/rendition
that referenced
this pull request
Oct 10, 2024
…issues See: qntm/hatetris#151 Change-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per enzymejs/enzyme#2518 (comment),
enzymeis obviously no longer actively maintained. This PR moves us to use@testing-library/reactinstead.As a part of this I first migrated from using
shallowto usingmountin unit testing -shallowwas always a poor choice and really should not have been used. Then, I migrated to usingdata-testidproperties instead of class selectors, which is also a better approach overall. Some older unit tests have been scrapped. Some very detailed assertions regarding<Game>'s internal state have had to be scrapped. I might need to figure out a better approach to this. Also, no more snapshot testing. Does<Well>even really need its own unit tests? Lastly,<Game>has been modified to actually render certain startup errors, instead of just throwing. This was done just because it was easier to maintain.Up next: esbuild, maybe? Probably some upgrades to newer versions of React, too. And, I need to make those replay tests faster and more efficient. Hooks? And there are a few bugs to address: whitespace in replays, and asynchronous AIs.