fix: properly close streaming requests when not completely consumed

[Tasssadar]

https://requests.readthedocs.io/en/latest/user/advanced/#body-content-workflow

If you set stream to True when making a request, Requests cannot release the connection back to the pool unless you consume all the data or call Response.close. This can lead to inefficiency with connections.

In our case, with combination with Artifactory, these open connections are stuck in the middle of a download, because Artifactory does not support the Range requests for lazy wheel.

Not sure if I need to write test for this, let me know if so.

[Tasssadar]

I just found that this does not really matter if we were using just requests, because finalizers would take care of closing the responses - but there is also a bug in cachecontrol, which creates circular references and prevents the finalizers from working: psf/cachecontrol#344

We should still be closing the responses here though, as that is what the docs say.

[radoering]

Good catch. 👍

Not sure if I need to write test for this, let me know if so.

Do you think a test makes sense? If the only way to test it, is to assert that close() is called, it may not be worth it.

[Tasssadar]

Good catch. 👍

Not sure if I need to write test for this, let me know if so.

Do you think a test makes sense? If the only way to test it, is to assert that close() is called, it may not be worth it.

Fixed the exception type. In my opinion, the test do not make much sense, as they would be pretty fragile and would not check any new places where requests usage could be added in the future.

[racinmat]

Hi, when can we expect this being released to pypi?