fix #13031: use the concrete id NOTSET for the empty parameter list #13073
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
…ter list stand-in this ensures we dont invoke idfunc with the internal NOTSET enum token
RonnyPfannschmidt
force-pushed
the
ronny/fix-13031-parametrize-empty-concrete-id
branch
from
c87c874 to
da7251c
Compare
nicoddemus
reviewed
Dec 18, 2024
| @@ -0,0 +1,2 @@ | |||
| ``pytest.mark.parametrize([], isfunc=...)`` will no longer call the idfunc with the internal ``NOTSET`` | |||
There was a problem hiding this comment.
isfunc? Is that correct?
Also can you rewrite this from the POV of an user? I mean the description by itself is hard to understand without reading the associated issue first.
| import pytest | ||
|
|
||
| def idfunc(value): | ||
| raise ValueError() |
There was a problem hiding this comment.
IIUC idfunc is no longer being called when parametrize receives an empty list, is that it?
There was a problem hiding this comment.
correct , the exception here is to ensure its never getting triggered
nicoddemus
reviewed
Dec 18, 2024
Comment on lines
+1058
to
+1059
| def idfunc(value): | ||
| raise ValueError() |
There was a problem hiding this comment.
Suggested change
| def idfunc(value): | |
| raise ValueError() | |
| def idfunc(value): | |
| raise ValueError() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures we dont invoke idfunc with the internal NOTSET enum token
closes #13031