migrate to https://github.com/hynek/build-and-inspect-python-package/ #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RonnyPfannschmidt
commented
Aug 17, 2024
RonnyPfannschmidt
commented
- migrate to pyproject.toml tooling
- migrate to https://github.com/hynek/build-and-inspect-python-package/
nicoddemus
approved these changes
Sep 9, 2024
.github/workflows/main.yml
Outdated
| run: python -m build --sdist --wheel --outdir dist/ | ||
|
|
||
| name: Packages | ||
| path: dist | ||
| - name: Publish package | ||
| uses: pypa/[email protected] |
There was a problem hiding this comment.
While at it let's try the new attestations support:
Suggested change
| uses: pypa/gh-action-pypi-publish@v1.9.0 | |
| uses: pypa/gh-action-pypi-publish@v1.10.1 | |
| with: | |
| attestations: true |
pyproject.toml
Outdated
| [project] | ||
| name = "pluggy" | ||
| license = {text = "MIT"} | ||
| authors = [{name = "Holger Krekel", email = "[email protected]"}] |
There was a problem hiding this comment.
While at it should we update this? Not sure to what exactly though...
There was a problem hiding this comment.
I'm up for being on the hook
There was a problem hiding this comment.
I'm up for being on the hook
There was a problem hiding this comment.
I was thinking more if it is appropriate to add pytest core team <[email protected]> or something like that.
pyproject.toml
Outdated
| name = "pluggy" | ||
| license = {text = "MIT"} | ||
| authors = [{name = "Holger Krekel", email = "[email protected]"}] | ||
| classifiers = ["Development Status :: 6 - Mature", "Intended Audience :: Developers", "License :: OSI Approved :: MIT License", "Operating System :: POSIX", "Operating System :: Microsoft :: Windows", "Operating System :: MacOS :: MacOS X", "Topic :: Software Development :: Testing", "Topic :: Software Development :: Libraries", "Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11"] |
There was a problem hiding this comment.
Suggested change
| classifiers = ["Development Status :: 6 - Mature", "Intended Audience :: Developers", "License :: OSI Approved :: MIT License", "Operating System :: POSIX", "Operating System :: Microsoft :: Windows", "Operating System :: MacOS :: MacOS X", "Topic :: Software Development :: Testing", "Topic :: Software Development :: Libraries", "Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11"] | |
| classifiers = [ | |
| "Development Status :: 6 - Mature", | |
| "Intended Audience :: Developers", | |
| "License :: OSI Approved :: MIT License", | |
| "Operating System :: POSIX", | |
| "Operating System :: Microsoft :: Windows", | |
| "Operating System :: MacOS :: MacOS X", | |
| "Topic :: Software Development :: Testing", | |
| "Topic :: Software Development :: Libraries", | |
| "Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", | |
| "Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", | |
| "Programming Language :: Python :: 3 :: Only", | |
| "Programming Language :: Python :: 3.8", | |
| "Programming Language :: Python :: 3.9", | |
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| ] |
RonnyPfannschmidt
force-pushed
the
baipp
branch
from
4816b4b to
0723def
Compare
|
@RonnyPfannschmidt gentle ping here. |
nicoddemus
approved these changes
Dec 11, 2024
Comment on lines
+21
to
+22
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Out of curiosity, why is this needed?
And if is needed, why we don't use fetch-depth=0 in the test job?
| @@ -93,9 +103,11 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Download built packages from the build-package job. | |||
There was a problem hiding this comment.
Suggested change
| - name: Download built packages from the build-package job. | |
| - name: Download built packages from the check-package job. |
| fetch-depth: 0 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| - name: Download built packages from the build-package job. |
There was a problem hiding this comment.
Suggested change
| - name: Download built packages from the build-package job. | |
| - name: Download built packages from the check-package job. |
|
Probably worth updating the title/description of the PR before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.