Split CI workflows into 'test' and 'deploy' #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
changed the title
This makes them easier to maintain and follows how other pytest repositories have evolved. Also made some changes to the deploy workflow: * Using Python 3.10 * Using `build` package instead of calling `python setup.py`
nicoddemus
force-pushed
the
split-workflows
branch
from
f5e652d to
e1227ad
Compare
nicoddemus
commented
Nov 15, 2022
| tags: | ||
| - "*" | ||
|
|
||
| permissions: {} |
|
im a bit unhappy with the splitting, i'd prefer if we started to install from the build artifacts for testing (like i have done for some of my projects) |
What do you mean? IIUC, you mean to test the package instead of source, but isn't that what Or do you mean to generate a single artifact, test over it, and then deploy that same artifact? |
|
Happy to try out something like that, can you point to a project to use as reference? |
|
@nicoddemus i'd love to extract this into something reusable, but currently im a bit tied up with other priorities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them easier to maintain and follows how other pytest repositories have evolved.
Also made some changes to the deploy workflow:
buildpackage instead of callingpython setup.py