Add more Line attributes
#3268
Open
Add more Line attributes
#3268
+328
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- center - centerx/y - angle - slope Co-authored-by: Emc2356 <[email protected]> Co-authored-by: NovialRiptide <[email protected]> Co-authored-by: ScriptLineStudios <[email protected]> Co-authored-by: Avaxar <[email protected]> Co-authored-by: maqa41 <[email protected]>
itzpr3d4t0r
added
New API
damusss
requested changes
Dec 16, 2024
docs/reST/ref/geometry.rst
Outdated
| | :sl:`the coordinate of the middle point of the line` | ||
| | :sg:`center -> (float, float)` | ||
|
|
||
| The center of the line. Calculated using the `((xa + xb) / 2, (ya + yb) / 2)` formula. |
There was a problem hiding this comment.
This is for consistency, new docs should use ax and ay
docs/reST/ref/geometry.rst
Outdated
|
|
||
| The angle of the line representing its orientation. Calculated using | ||
| the `atan2(yb - ya, xb - xa)` formula. This attribute is read-only, it cannot | ||
| be reassigned. To change the line's angle use the `rotate` method or change |
There was a problem hiding this comment.
Unless I'm blind, the rotate method doesn't exist yet, does it have to be ported or was it descarted?
There was a problem hiding this comment.
Yep it's yet to be ported, changed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following
Lineattributes:Credits
Geometry Project:
For code, docs and tests:
@novialriptide @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar @Matiiss @newpaxonian @maqa41 @blankRiot96
Also thanks to @Starbuck5 for kickstarting the idea and the occasional help!
Functionality added in this PR
geometry.pyihttps://github.com/pygame-community/pygame-geometry/blame/main/geometry.pyi
Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar
geometry.rsthttps://github.com/pygame-community/pygame-geometry/blame/main/docs/line.rst
Credits to @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar
line.chttps://github.com/pygame-community/pygame-geometry/blame/main/src_c/line.c
Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar
geometry.hhttps://github.com/pygame-community/pygame-geometry/blame/main/src_c/include/geometry.h
Credits to @Emc2356 @itzpr3d4t0r @maqa41
geometry_test.pyhttps://github.com/pygame-community/pygame-geometry/blame/main/test/test_line.py
Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar