-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add HTML mixin if not building html #2076
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me, but just FYI, I am unable to reproduce the bug.
Using:
- my own small example docs repo (which has a RST table)
- Sphinx 8.1.3
- PyData Sphinx Theme 0.16.0
- Python 3.13
I ran make latexpdf
but I did not get any errors.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I recommend waiting to merge until after 0.16.1 is out. This seems innocuous but I would hate to break a bunch of user sites and have to scramble to cut a |
@drammock, agreed |
@gabalafou thanks to your minimal example I was able to find my mistake: I listed the I anyway think the fix makes sense. :) |
When attempting to build the
latexpdf
target, pydata-sphinx-theme 0.16 currently fails on Sphinx 8.1.3 with:The issue appears to be that the
BootstrapHTML5Mixin
is added despite the target not beinghtml
. This PR moves the check forapp.builder.format
to the top level ofsetup_translators
.(cc) @stephanlachnit