Revert caching a default SSLContext #6767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
remove_cached_sslcontext
branch
from
ce40c46 to
d520f46
Compare
nateprewitt
commented
Jul 18, 2024
| cert_reqs = "CERT_REQUIRED" | ||
| if verify is False: | ||
| cert_reqs = "CERT_NONE" | ||
| elif verify is True and should_use_default_ssl_context: | ||
| pool_kwargs["ssl_context"] = _preloaded_ssl_context | ||
| elif isinstance(verify, str): | ||
| if not os.path.isdir(verify): |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes from #6667 to the previous behavior. Due to the number of edge cases and concurrency issues we've encountered with this change, we've decided the benefit doesn't currently outweigh the pain to existing infrastructure. We've iterated on a few tries to keep this functionality in place, but are still receiving reports of novel issues with this behavior.
We may be able to revisit this in a later version of Requests but we'll need a much more comprehensive test plan.