collectors/mdadm_linux: support reshape status + expose remaining mdstats #3163
+193
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamcore
force-pushed
the
feat/mdstat-reshape
branch
2 times, most recently
from
cca725b to
0bae5cf
Compare
collector/mdadm_linux.go
Outdated
| @@ -98,6 +104,31 @@ var ( | |||
| []string{"device"}, | |||
| nil, | |||
| ) | |||
|
|
|||
| blocksToBeSyncedDesc = prometheus.NewDesc( | |||
| prometheus.BuildFQName(namespace, "md", "blocks_tobesynced"), | |||
There was a problem hiding this comment.
why not to_be_synced? Seems better
collector/mdadm_linux.go
Outdated
| nil, | ||
| ) | ||
| blocksSyncedPctDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "md", "blocks_synced_pct"), |
There was a problem hiding this comment.
Ideally we would have a blocks_synced so this can be calculated from blocks_to_by_synced
There was a problem hiding this comment.
No need to calculate anything, since we already have blocks_synced. I just added this bit, so all available data is exported (and it's one thing less to manually calculate later on in PromQL).
There was a problem hiding this comment.
Ah I missed this. In that case just remove the blocks_synced_pct. This can be easily and cheaply calculated in PromQL and therefor is best practice to not expose it
tamcore
force-pushed
the
feat/mdstat-reshape
branch
2 times, most recently
from
f50c7a0 to
e86fd7f
Compare
…tats Signed-off-by: Philipp Born <[email protected]>
tamcore
force-pushed
the
feat/mdstat-reshape
branch
from
e86fd7f to
fc1f2bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires prometheus/procfs#679
This change allows the mdadm collector to properly catch raids that are currently undergoing conversion (reshaping), i.e. from RAID1 to RAID5.
Additionally, it also exposes the remaining stats like sync speed / percentage, etc.