Estimate StringBuilder capacity for exported names #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate metric names, we use the default
StringBuilder
constructor, which allocates a 16 character buffer.
Most metrics will exceed this, especially when we start adding
attributes to it.
This causes
StringBuilder
to "grow", automatically, by allocating anew array and copying its contents over to it. Each time it only grows
enough to contain the
append
ed String, which means we need to grow onalmost every
append
call.While allocating new memory is cheap in the JVM, copying memory is not.
These copies add up, especially with a large number of long-named
metrics with many attributes.
Instead, we can calculate the necessary capacity of the
StringBuilder
up-front, which should avoid doing any copying during
append
.Signed-off-by: Nick Telford [email protected]