-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing examples to the documentation. #6751
base: main
Are you sure you want to change the base?
Conversation
It looks like currently tests are failing from a linting error:
(I haven't taken a closer look just yet at the changes, I'll do that soon. Thanks for taking on this task and adding so many examples!) |
I'll fix these.. |
Thank you @deveshidwivedi for raising this point. It's essential for new learners who may struggle with understanding concepts without clear examples. Your examples are excellent. I'd like to add a few cleanup for this one. :) |
Thank you!@perminder-17 |
@perminder-17 You seem to have started the review but not submitted it, on the top right of the code review page you need to press "Review changes" > "Submit review" for it to show up. |
* function setup() { | ||
* createCanvas(150, 150); | ||
* pixelDensity(4); | ||
* pg = createGraphics(75, 75); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm uncertain about whether we should include examples in all files containing the same method, such as pixelDensity, which is present in three files. If it's advisable, we could consider adding relevant examples in each corresponding file. What are your thoughts on this matter? for the example (pixelDensity), I believe we're referring to the method created on p5.framebuffer. Could we include an example related to using framebuffer instead of createGraphics? This might provide more relevant examples. What you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for p5.Framebuffer.pixelDensity
it would indeed be more relevant to add an example using framebuffer instead of createGraphics.
Thanks... My bad😂 |
Resolves #6750
Changes: Added some of the missing examples.
Before:
After:
PR Checklist
npm run lint
passes