Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored CollectionList and CollectionListRow #2971

Closed

Conversation

vivekbopaliya
Copy link
Contributor

@vivekbopaliya vivekbopaliya commented Jan 28, 2024

Related to #2179 and #824

Changes:

  • Migrated CollectionList into functional component
  • Shifted them from props drilling to redux hooks

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good for the most part, but we have some other proposed changes to the CollectionList component which will definitely conflict so I don't know what the plan is. #2376

@vivekbopaliya
Copy link
Contributor Author

This looks pretty good for the most part, but we have some other proposed changes to the CollectionList component which will definitely conflict so I don't know what the plan is. #2376

Ahhhhh, it appears that several components were optimized along with two new Table and TableRow have been added. i didn't check the PR. my bad. although as it is pretty huge PR and i see it is in still development (as some of test cases got failed ;) ) hence, we are not sure when will it get merged as yet. in meantime, i am moving forward and fix the changes that you requested.

@vivekbopaliya
Copy link
Contributor Author

Additionally, we might want to seperate SketchListRow from SketchList and place it in its own file. I have worked on it and almost did wrap up migrating them into functional components and importing individual actions rather than prop drilling but eventually, it boiled down to failing one of 20 test errors even tho both components are completely working. I think while refactoring them, we will have to rewrite SketchList.unit.test component as well.

Although I have never worked on testing before 😬, let me know if you want me to raise a PR, and we can further discuss what changes are required in the unit test component. (could be a mini collab?!)

@lindapaiste
Copy link
Collaborator

This looks pretty good for the most part, but we have some other proposed changes to the CollectionList component which will definitely conflict so I don't know what the plan is. #2376

Ahhhhh, it appears that several components were optimized along with two new Table and TableRow have been added. i didn't check the PR. my bad. although as it is pretty huge PR and i see it is in still development (as some of test cases got failed ;) ) hence, we are not sure when will it get merged as yet. in meantime, i am moving forward and fix the changes that you requested.

Yeah everything regarding the list/table components has been kind of up in the air due to this major rewrite which has been in the works for a long time.

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2024

Thanks so much for submitting this and I'm sorry it took a while to get to this!

Although it's a bigger PR, it does address a lot of the refactoring needs so I think we ultimately might want to go with #2376, since it was raised first! In that vein, I'm going to close this one for now, but maybe some changes here could also be referenced in the other one as well?

@raclim raclim closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants