-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored CollectionList and CollectionListRow #2971
Refactored CollectionList and CollectionListRow #2971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good for the most part, but we have some other proposed changes to the CollectionList
component which will definitely conflict so I don't know what the plan is. #2376
client/modules/IDE/components/CollectionList/CollectionList.jsx
Outdated
Show resolved
Hide resolved
client/modules/IDE/components/CollectionList/CollectionList.jsx
Outdated
Show resolved
Hide resolved
client/modules/IDE/components/CollectionList/CollectionList.jsx
Outdated
Show resolved
Hide resolved
Ahhhhh, it appears that several components were optimized along with two new Table and TableRow have been added. i didn't check the PR. my bad. although as it is pretty huge PR and i see it is in still development (as some of test cases got failed ;) ) hence, we are not sure when will it get merged as yet. in meantime, i am moving forward and fix the changes that you requested. |
…aliya/p5.js-web-editor into refactor/CollectionList
Additionally, we might want to seperate Although I have never worked on testing before 😬, let me know if you want me to raise a PR, and we can further discuss what changes are required in the unit test component. (could be a mini collab?!) |
Yeah everything regarding the list/table components has been kind of up in the air due to this major rewrite which has been in the works for a long time. |
Thanks so much for submitting this and I'm sorry it took a while to get to this! Although it's a bigger PR, it does address a lot of the refactoring needs so I think we ultimately might want to go with #2376, since it was raised first! In that vein, I'm going to close this one for now, but maybe some changes here could also be referenced in the other one as well? |
Related to #2179 and #824
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123