Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue cannot create a SharedArrayBuffer #2851

Conversation

goutamdh
Copy link

@goutamdh goutamdh commented Jan 6, 2024

Fixes #2094

Changes:
Set Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy headers This commit adds security headers to the server response to enable cross-origin isolation for shared memory operations in the p5.js editor.
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

… headers This commit adds security headers to the server response to enable cross-origin isolation for shared memory operations in the p5.js editor.
Copy link

welcome bot commented Jan 6, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste lindapaiste added the Area:Preview For features and bugs relating to the embedded preview sketch label Jan 9, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

Thanks for your work on this! After testing this, I don't think what's here is the complete solution yet since the issue seems to still persist on my end! I don't exactly know what the right resolution looks like myself, but I feel like what's here is probably going in that vein. Since we have quite a few PRs open at the moment I'm going to close this one for now. I'm sorry that we couldn't get this one in, but please feel free to reopen this with any updates or check out our other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Preview For features and bugs relating to the embedded preview sketch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a SharedArrayBuffer
3 participants