Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes of the issue window.p5._report is not defined #2426

Merged
merged 4 commits into from
Sep 14, 2023
Merged

fixes of the issue window.p5._report is not defined #2426

merged 4 commits into from
Sep 14, 2023

Conversation

Ankush263
Copy link
Contributor

Fixes #2327

Changes:
sketchDoc.head.appendChild(previewScripts); -> sketchDoc.body.appendChild(previewScripts);

I have verified that this pull request:

  • [✅ ] has no linting errors (npm run lint)
  • [✅ ] has no test errors (npm run test)
  • [✅ ] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [✅ ] is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste merged commit 27a96ac into processing:develop Sep 14, 2023
1 check passed
@lindapaiste lindapaiste mentioned this pull request Oct 21, 2023
Closed
@raclim raclim mentioned this pull request Oct 31, 2023
Merged
@lindapaiste lindapaiste mentioned this pull request Dec 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

window.p5._report is not defined
2 participants
@Ankush263 @lindapaiste