Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:- Drop down menu cannot be right-clicked #2414

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

Biki-das
Copy link

@Biki-das Biki-das commented Sep 11, 2023

Fixes #2359

the onMouseUp event whenever triggered causes the drop down state changed to none thus closing it, i have added a early return check to look for the right click.

Screen.Recording.2023-09-11.at.6.04.05.PM.mov

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@Biki-das Biki-das mentioned this pull request Sep 12, 2023
4 tasks
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for fixing this!

I need to checkout your branch and run it before I merge it, to make sure that it actually works. but code-wise it looks good.

@Biki-das
Copy link
Author

🚀 Thanks for fixing this!

I need to checkout your branch and run it before I merge it, to make sure that it actually works. but code-wise it looks good.

Cool! Yeah i have also attached a screen recording of the expected behaviour!

@lindapaiste lindapaiste changed the title Fix:- Drop down menu cannot be clicked Fix:- Drop down menu cannot be right-clicked Sep 13, 2023
@lindapaiste lindapaiste merged commit da9900c into processing:develop Sep 13, 2023
1 check passed
@Biki-das Biki-das deleted the bug-dropdown-p5js branch September 14, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menu items cannot be right-clicked
2 participants