Account Settings Page UI for mobile devices #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-80f3ee8266 |
4 tasks
lindapaiste
requested changes
Sep 17, 2023
| @@ -57,13 +57,18 @@ | |||
|
|
|||
| .form__input { | |||
| max-width: 90vw; | |||
| width: #{360 / $base-font-size}rem; | |||
| // width: #{360 / $base-font-size}rem; | |||
| width: 100%; | |||
There was a problem hiding this comment.
This change has unintended consequences as it's used on all form inputs. Check out the login and signup pages on desktop. We might need an override that it specific to the account settings page.
There was a problem hiding this comment.
hey @lindapaiste, sorry for late response, I just fixed the problem, please check it out
lindapaiste
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Account Settings Page UI Update in small devices
I have verified that this pull request:
npm run lint)npm run test)developbranch.