Feature generic table #1786
Closed
Feature generic table #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier DashBoardView used to render the Table component for SketchList, CollectionList, AssetsList. Now DashboardView renders SketchTable, CollectionTable, AssetsTable components and these three render the Table component
Earlier asset rows, sketch rows, collection rows all were rendered in TableRow component, now these rows are rendered in AssetTable, SketchTable, CollectionTable and then passed to Table component
… SketchListRow, move CollectionListRow.jsx to ../
earlier (field and direction) state was used for sorting, now (field, type and direction) state is used
In the current component structure Searchbar is the child of DashboardView and Overlay so if react state is used,the search state will have to be passed through Searchbar -> DashboardView -> ..... -> Table and Searchbar -> Overlay -> ..... -> Table but with redux its more simpler: Searchbar -> redux store, redux store -> Table
…e Asset Table has no searchbar
…/desc button use React.Fragment instead of <div> in SketchTable, CollectionTable
…nd 1st data row's background colors were matching in AddToCollectionList and AddToCollectionSketchList due to which it was difficult to differentiate b/w table header and data.
delete reducers/sorting.js, actions/sorting.js had searching actions also so rename sorting.js to search.js and delete sorting actions from it, delete getFilteredCollections and getSortedCollections from selectors/collections.js, delete selectors/projects.js, delete TableRow.jsx
Release Environmentsp5.js-web-editor |
|
Thanks for your patience in my getting back to you on this! I've been on a GitHub hiatus and am now reviewing PRs again. I have some suggestions for changes—are you able to work more on this or should I make them? |
|
I will not be able to manage time for this due to other works these days. You can make the changes. |
|
Thank you so much for taking the time to contribute to this issue—I'm sorry we couldn't get to your work in time! Since some time has passed I'm going to close this for now, but please feel free to reopen this or work on this again, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123SketchList, CollectionList, AssetList, AddToCollectionList, AddToCollectionSketchList and Collection use the Table component. The Table component has the sorting state, sorting function, searching function. Search state is in redux.
Also I was not able to test the AssetList due to some error (Error: getaddrinfo ENOTFOUND s3) ( at line .get(s3/objects) inside getAssets() ). After this error app used to crash.
hi @catarak please review the changes.