Jump through progress bar + Other fixes #2
+399
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksen0
reviewed
Dec 16, 2024
| @@ -1,7 +1,7 @@ | |||
| var main = { | |||
| sketch: null, | |||
| scaleFactor: 1.0, | |||
| debug: false, | |||
| debug: true, | |||
There was a problem hiding this comment.
Yes! Fixing it now
ksen0
reviewed
Dec 16, 2024
| @@ -20,7 +19,7 @@ var main = { | |||
| console.log(script.popcorn.currentTime()); | |||
| var clickX = e.pageX - ($(window).width() / 2) | |||
| clickY = $(window).height() - e.pageY; | |||
| console.log("{left:" + clickX + ", top:" + clickY + "}"); | |||
| console.log("{left:" + e.pageX + ", top:" + clickY + "}"); | |||
There was a problem hiding this comment.
Sometimes when debugging, we need to fix the CSS with this.
ksen0
reviewed
Dec 16, 2024
| @@ -2,7 +2,7 @@ var script = { | |||
| popcorn: null, | |||
| init: function () { | |||
|
|
|||
| var pop = Popcorn.smart("#videoClip", ["https://storage.cloud.google.com/hello-p5-bucket/p5-video-draft-3.webm", "https://storage.cloud.google.com/hello-p5-bucket/p5-video-draft-3.mp4"], { width: 1920, height: 1080 }); | |||
| var pop = Popcorn.smart("#videoClip", ["/assets/p5-video-draft-4.webm", "/assets/p5-video-draft-4.mp4"], { width: 1920, height: 1080 }); | |||
There was a problem hiding this comment.
@tuantinghuang The public link is here: https://hello-assets.p5js.org/p5-video-draft-3.webm - please check if this works?
There was a problem hiding this comment.
There was a problem hiding this comment.
Both link works, thank you! I will send the newest version of the video files once I fix more things!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is adding in the feature to allow viewers to jump through video timeline with different sections. Also did some other fixes:
The video files used in the code now can be downloaded here and run local temporarily. Will transfer to Processing's CDN once the video files are finalized.