-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename status "drafts" to "experimental" #3885
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question, for the default story we've been adding a prefix over in: https://github.com/primer/react/blob/main/script/components-json/build.ts#L42-L49 for the component json stuff, with this change will we need to make sure the stories are also updated with this new status so the prefix ends up working out?
➕ 1 And I think we will also need to make sure the ids are updated in the Playwright tests i.e. from being |
"name": "UnderlineNav", | ||
"status": "draft", | ||
"status": "experimental", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to this PR but we should update the status of UnderlineNav to Beta (I'll push a PR)
Oooh, good catch! I was hoping to break the change into multiple smaller PRs, looks like we can't! Update: Or maybe we can by temporarily using const storyPrefix = {
draft: 'drafts-',
- experimental: 'experimental-',
+ experimental: 'drafts-', // temporarily also point at drafts
} |
This is bigger than I wanted to tackle on that day. Closing PR as outdated |
One tiny part of implementing ADR 010: Merge drafts status into experimental.
This would update https://primer.style/guides/status