Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename status "drafts" to "experimental" #3885

Closed
wants to merge 2 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 31, 2023

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 31, 2023
@siddharthkp siddharthkp self-assigned this Oct 31, 2023
@siddharthkp siddharthkp requested review from a team and mperrotti October 31, 2023 11:22
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: b411b1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (0%)
dist/browser.umd.js 104.13 KB (0%)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, for the default story we've been adding a prefix over in: https://github.com/primer/react/blob/main/script/components-json/build.ts#L42-L49 for the component json stuff, with this change will we need to make sure the stories are also updated with this new status so the prefix ends up working out?

@broccolinisoup
Copy link
Member

Quick question, for the default story we've been adding a prefix over in: https://github.com/primer/react/blob/main/script/components-json/build.ts#L42-L49 for the component json stuff, with this change will we need to make sure the stories are also updated with this new status so the prefix ends up working out?

➕ 1 And I think we will also need to make sure the ids are updated in the Playwright tests i.e. from being drafts-components-tooltip-default to experimental-components-tooltip-default

"name": "UnderlineNav",
"status": "draft",
"status": "experimental",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to this PR but we should update the status of UnderlineNav to Beta (I'll push a PR)

@siddharthkp
Copy link
Member Author

siddharthkp commented Nov 1, 2023

Quick question, for the default story we've been adding a prefix over in: https://github.com/primer/react/blob/main/script/components-json/build.ts#L42-L49 for the component json stuff, with this change will we need to make sure the stories are also updated with this new status so the prefix ends up working out?

Oooh, good catch! I was hoping to break the change into multiple smaller PRs, looks like we can't!

Update: Or maybe we can by temporarily using drafts- prefix for experimental as well. There are no experimental- stories yet! Thoughts?

 const storyPrefix = {
    draft: 'drafts-',
-    experimental: 'experimental-',
+    experimental: 'drafts-', // temporarily also point at drafts
}

@siddharthkp siddharthkp marked this pull request as draft December 5, 2023 14:57
@siddharthkp
Copy link
Member Author

This is bigger than I wanted to tackle on that day. Closing PR as outdated

@siddharthkp siddharthkp deleted the rename-status-drafts-to-experimental branch October 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants