Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace execa with tinyexec #195

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ziebam
Copy link

@ziebam ziebam commented Sep 4, 2024

This PR replaces execa with a lighter alternative.

Some notes:

  1. tinyexec only provides an asynchronous API. My changes aim to keep the existing behavior through async/await, while also following the ESLint rules (e.g. not inlining (await func(...)).stdout but extracting the await output to a separate variable).
  2. I went ahead and added some miscellaneous things to .gitignore for smoother DX. 😄
  3. I tackled the comments regarding mocking execaSync (now x). Please let me know if you'd prefer to keep the old approach.

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 7c80949

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pretty-quick Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Sep 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ziebam ziebam changed the title chore: Replace execa with tinyexec chore: replace execa with tinyexec Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant