Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add THMC 4 wiki article #12552

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add THMC 4 wiki article #12552

wants to merge 20 commits into from

Conversation

RushFTK
Copy link
Contributor

@RushFTK RushFTK commented Dec 13, 2024

Self-check

Internal Review

  • Rulebooks
  • Grammer
  • Add artwork resources / link
    • Banner
    • Bracket image
  • Links

@RushFTK
Copy link
Contributor Author

RushFTK commented Dec 13, 2024

Some questions:

  • Since the artwork resources will also used in news post, need i reupload in this folder again?
  • Should we add links to new posts or 3rd platform like liquipedia?

- fix wrong item order
- remove dumplicated end lines.
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
RushFTK and others added 4 commits December 13, 2024 16:58
Apply @iSlodinxOsu's suggestion on word glitch

Co-authored-by: iSlodinx <[email protected]>
- Update tournaments page to consist with latest en one
- Fix incident problem
- Add missing new lines.
- add missing lines
- fix inline urls links
@RushFTK RushFTK marked this pull request as draft December 13, 2024 13:17
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
Apply review from `Akace100` in `THMC4` wiki page

Co-authored-by: akace100 <[email protected]>
Copy link
Contributor Author

@RushFTK RushFTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some edit will casue conflict, please double check

- The winner of the `!roll` decides which team **picks** and **protect** first.
- The loser of the `!roll` decides which team **bans** first.
4. After order determined, the pick and ban phase will have the following steps:
1. First team protect a beatmap, followed by another team.They may not protect the same beatmap. Protected beatmaps may not be banned.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not consist with line 199 - 200) (teams could decided pick / ban order).

wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@RushFTK RushFTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add future discussion on @akace100 ‘s review

- The winner of the `!roll` decides which team **picks** and **protect** first.
- The loser of the `!roll` decides which team **bans** first.
4. After order determined, the pick and ban phase will have the following steps:
1. First team protect a beatmap, followed by another team.They may not protect the same beatmap. Protected beatmaps may not be banned.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it discussion result with other hosts? i mean not only grammer need rechecked, the writing rules suit for actually rules should also checked. i just write document and giving suggestion, not have any permission to determined.

wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
Comment on lines 202 to 205
1. First team protect a beatmap, followed by another team.They may not protect the same beatmap. Protected beatmaps may not be banned.
2. First team ban a map, followed by another team.
3. (If it’s in group stage) First team ban second map, followed by another team.
4. First team pick a map.
Copy link

@attempting-to-program attempting-to-program Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. First team protect a beatmap, followed by another team.They may not protect the same beatmap. Protected beatmaps may not be banned.
2. First team ban a map, followed by another team.
3. (If it’s in group stage) First team ban second map, followed by another team.
4. First team pick a map.
1. First team protects a beatmap, followed by another team. They may not protect the same beatmap. Protected beatmaps may not be banned.
2. First team bans a map, followed by another team.
3. (If it’s in group stage) First team bans the second map, followed by another team.
4. First team picks a map.

wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
RushFTK and others added 2 commits December 16, 2024 15:47
Apply iSlodinxOsu's code review on `THMC4` wiki

Co-authored-by: iSlodinx <[email protected]>
Copy link
Contributor

@iSlodinxOsu iSlodinxOsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces on it are necessary

wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/TMC/4th/en.md Outdated Show resolved Hide resolved
Apply iSlodinxOsu's review

Co-authored-by: iSlodinx <[email protected]>
Apply akace's grammar review

Co-authored-by: akace100 <[email protected]>
RushFTK and others added 4 commits December 17, 2024 23:52
Apply reviews from @akace100 in `THMC4` wiki pages
Also changes rules to compare each maps

Co-authored-by: akace100 <[email protected]>
- using name list on qualifier ranking
- using margin version bracket image instead of old one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants