Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add Gameplay/Daily_challenge #12544

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[FR] Add Gameplay/Daily_challenge #12544

wants to merge 4 commits into from

Conversation

sbnh1
Copy link
Contributor

@sbnh1 sbnh1 commented Dec 10, 2024

Self-check

Translation of the article “daily challenge” into French


| | Niveau | Participation totale | Série quotidienne | Série hebdomadaire |
| --: | :-: | :-: | :-: | :-: |
| ![Lustrous tier](img/tiers/lustrous.png) | Brillant | 1080 jours | 360 jours | 53 semaines |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure alt text also needs to be translated, atleast that was done for the Spanish and Polish translations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's an oversight of my part, I change that.

@sbnh1
Copy link
Contributor Author

sbnh1 commented Dec 11, 2024

if french reviewers have a better translation for Lustrous. I take it, I don't know if it's the best translation at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants