Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client/Menu tips #12538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

The-Last-Cookie
Copy link
Contributor

osu! #30865 added localisation support for in-game menu tips.

This PR reflects this change by:

  • adding a link to Crowdin in the main comment
  • removing the banner saying that "the strings are only available in English for now" (if present)

Self-check

@@ -8,7 +8,7 @@ tags:
- Hinweise
---

<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips aren't localised yet, but it's ok to translate them here while noting that they don't have translations in-game. -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de -->

@@ -6,7 +6,7 @@ tags:
- hints
---

<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips aren't localised yet, but it's ok to translate them here while noting that they don't have translations in-game. -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656 -->

@@ -10,7 +10,7 @@ tags:
- pistas
---

<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips aren't localised yet, but it's ok to translate them here while noting that they don't have translations in-game. -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-es -->

@@ -11,7 +11,7 @@ tags:
- conseils
---

<!-- Pour les traducteurs : pour traduire cette page, sélectionnez la langue correspondante dans stable et ouvrez `Localisation/fr.txt` dans votre dossier d'installation d'osu!. Les clés de traduction commençant par MenuTip_ et EditorTip_ contiennent les astuces traduites correspondantes. Les astuces de lazer ne sont pas encore localisées, mais il est possible de les traduire ici tout en notant qu'elles n'ont pas de traduction dans le jeu. -->
<!-- Pour les traducteurs : pour traduire cette page, sélectionnez la langue correspondante dans stable et ouvrez `Localisation/fr.txt` dans votre dossier d'installation d'osu!. Les clés de traduction commençant par MenuTip_ et EditorTip_ contiennent les astuces traduites correspondantes. Les astuces de lazer sont accessibles sur Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Pour les traducteurs : pour traduire cette page, sélectionnez la langue correspondante dans stable et ouvrez `Localisation/fr.txt` dans votre dossier d'installation d'osu!. Les clés de traduction commençant par MenuTip_ et EditorTip_ contiennent les astuces traduites correspondantes. Les astuces de lazer sont accessibles sur Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
<!-- Pour les traducteurs : pour traduire cette page, sélectionnez la langue correspondante dans stable et ouvrez `Localisation/fr.txt` dans votre dossier d'installation d'osu!. Les clés de traduction commençant par MenuTip_ et EditorTip_ contiennent les astuces traduites correspondantes. Les astuces de lazer sont accessibles sur Crowdin: https://crowdin.com/editor/osu-web/656/en-fr -->

@@ -7,7 +7,7 @@ tags:
- 提示
---

<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips aren't localised yet, but it's ok to translate them here while noting that they don't have translations in-game. -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-de?view=comfortable&filter=basic&value=0 -->
<!-- For translators: to translate this page, select the corresponding language in stable and open `Localisation/XX.txt` in your osu! installation folder. Translation keys starting with MenuTip_ and EditorTip_ contain the respective translated tips. The lazer tips can be translated on Crowdin: https://crowdin.com/editor/osu-web/656/en-zhcn -->

@cl8n
Copy link
Member

cl8n commented Dec 8, 2024

I don't think your edit to the comment is getting across the right info. it's supposed to help translators of the wiki write this article by showing them where to source the tips, not show how to translate the tips in the game. I would think it can be stated similar to the stable info that comes before it, but I'm not actually sure where the best place to grab these would be

e: probably somewhere in here https://github.com/ppy/osu-resources/tree/master/osu.Game.Resources/Localisation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants