Skip to content

Commit

Permalink
Release v3.1.0 (#229)
Browse files Browse the repository at this point in the history
## 🎯 Aim

Create a new release

## ✅ What was done

- [X] Fixed bug when there's a space in the folder path causing serve
- [X] Refactor the action naming

---------

Co-authored-by: Dan Toft <[email protected]>
Co-authored-by: Nico De Cleyre <[email protected]>
  • Loading branch information
3 people authored Apr 27, 2024
1 parent 98f26d9 commit 14847c0
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,13 @@ And for Azure DevOps👇

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#upgrade-project)

- **Validate current project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.
- **Validate project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.

![Upgrade project](./assets/images/validate-project.png)

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#validate-current-project)

- **Rename current project** - Forget about manual work and let the extension rename your project and generate a new solution ID.
- **Rename project** - Forget about manual work and let the extension rename your project and generate a new solution ID.

![Rename](./assets/images/rename.png)

Expand Down
4 changes: 2 additions & 2 deletions assets/walkthrough/tasks-and-actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ And for Azure DevOps👇

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#upgrade-project)

- **Validate current project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.
- **Validate project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.

![Upgrade project](../images/validate-project.png)

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#validate-current-project)

- **Rename current project** - Forget about manual work and let the extension rename your project and generate a new solution ID.
- **Rename project** - Forget about manual work and let the extension rename your project and generate a new solution ID.

![Rename](../images/rename.png)

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "viva-connections-toolkit",
"displayName": "SharePoint Framework Toolkit",
"description": "SharePoint Framework Toolkit aims to boost your productivity in developing and managing SharePoint Framework solutions helping at every stage of your development flow, from setting up your development workspace to deploying a solution straight to your tenant without the need to leave VS Code and now even create a CI/CD pipeline to introduce automate deployment of your app. This toolkit is provided by the community.",
"version": "3.0.0",
"version": "3.1.0",
"publisher": "m365pnp",
"preview": false,
"homepage": "https://github.com/pnp/vscode-viva",
Expand Down
4 changes: 2 additions & 2 deletions src/panels/CommandPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ export class CommandPanel {
private static async actionsTreeView() {
const actionCommands: ActionTreeItem[] = [
new ActionTreeItem('Upgrade project', '', { name: 'arrow-up', custom: false }, undefined, Commands.upgradeProject),
new ActionTreeItem('Validate current project', '', { name: 'check-all', custom: false }, undefined, Commands.validateProject),
new ActionTreeItem('Rename current project', '', { name: 'whole-word', custom: false }, undefined, Commands.renameProject),
new ActionTreeItem('Validate project', '', { name: 'check-all', custom: false }, undefined, Commands.validateProject),
new ActionTreeItem('Rename project', '', { name: 'whole-word', custom: false }, undefined, Commands.renameProject),
new ActionTreeItem('Grant API permissions', '', { name: 'workspace-trusted', custom: false }, undefined, Commands.grantAPIPermissions),
new ActionTreeItem('Deploy project (sppkg)', '', { name: 'cloud-upload', custom: false }, undefined, Commands.deployProject),
new ActionTreeItem('Add new component', '', { name: 'add', custom: false }, undefined, Commands.addToProject),
Expand Down
2 changes: 1 addition & 1 deletion src/services/TerminalCommandExecuter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class TerminalCommandExecuter {
currentProjectPath = join(currentProjectPath, 'src');
}

TerminalCommandExecuter.runInTerminal(`cd ${currentProjectPath}`, terminal);
TerminalCommandExecuter.runInTerminal(`cd "${currentProjectPath}"`, terminal);
}

TerminalCommandExecuter.runInTerminal(command, terminal);
Expand Down

0 comments on commit 14847c0

Please sign in to comment.