ASGI Support

[masipcat]

#458

[dmanchon]

TODO:

• get rid of starlette.websockets.WebSocket dependency
• move WebSocketSession to async_asgi_testclient
• improve the IRequest interface
• AsgiStreamReader is not able to support HTTP2 should be reimplemented correctly

[bloodbare]

@masipcat that holds the merge until uvloops merge is done?

[masipcat]

@bloodbare The problem with uvloop is that the official release is built with Cython <0.29.12 (doesn't support python 3.8) and is distributed with binaries (python wheels). Building uvloop from source using Cython 0.29.13 works without any other change.

So, I don't think we need to wait, but it's up to you ;)

[vangheem]

Thoughts on git+https://github.com/dmontagu/uvloop@patch-1? Maybe not depend on 3.8 yet?

[masipcat]

I removed python 3.8 on travis and removed the git+https... in the requirements.

[masipcat]

TODO: find the best way to make these tests work, beucase the async_asgi_testclient doesn't start a http server to run the tests, it calls the app directly...

guillotina/guillotina/tests/test_server.py

Lines 47 to 56 in 2ed25be

	async def test_requester_with_default_settings(container_requester):
	async with container_requester as requester:
	assert requester.server.host == "127.0.0.1"
	@pytest.mark.app_settings({"test_server_settings": {"host": "0.0.0.0", "port": 8080}})
	async def test_requester_with_custom_settings(container_requester):
	async with container_requester as requester:
	assert requester.server.host == "0.0.0.0"
	assert requester.server.port == 8080

[masipcat]

@bloodbare @vangheem all tests passing again.

TODO:

• investigate if uvicorn/hypercorn reuse asyncio task (with http1.1 + keep alive)

[masipcat]

@bloodbare @vangheem all tests passing again.

TODO:

* investigate if uvicorn/hypercorn reuse asyncio task (with http1.1 + keep alive)

I checked uvicorn and hypercorn implemetantions and I found that both are creating a task for each request, as you can see here: https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/http/h11_impl.py#L234. Also, I think the H11Protocol is called for each request (or for each session if it has keep_alive) so, it reuses the task of the H11Protocol but creates a task for each request.

[vangheem]

@bloodbare I'm about to push the merge button after tests pass here.

@masipcat is it okay if I squash all the commits?

[masipcat]

@masipcat is it okay if I squash all the commits?

@vangheem yes!

[bloodbare]

💪👏