Feat: Add Amount to Card Fields for Improved BIN API Requests #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchoun
reviewed
Dec 13, 2024
| amount: { | ||
| type: "string", | ||
| queryParam: true, | ||
| value: getAmount, |
There was a problem hiding this comment.
getAmount() throws an error if no amount is passed in the data-attributes. Is this going to break existing integrations since data-amount is not currently documented to be passed?
There was a problem hiding this comment.
That's definitely a good call out.. will have to investigate more as to where else this is being used.
| @@ -714,6 +715,12 @@ export const getCardFieldsComponent: () => CardFieldsComponent = memoize( | |||
| value: getCurrency, | |||
| }, | |||
|
|
|||
| amount: { | |||
| type: "string", | |||
| queryParam: true, | |||
There was a problem hiding this comment.
I don't think queryParam is necessary here. Assuming that you plan on pulling the amount from xprops.
There was a problem hiding this comment.
Thanks, I just set it to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for an amount prop in the Card Fields component, enabling more accurate BIN API requests. The amount object, containing currency and value, is passed to the card-fields component and subsequently used in the BIN API request data. When unavailable, the value defaults to 0. This enhancement eliminates the use of dummy values, improving the precision of BIN lookups.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
https://paypal.atlassian.net/browse/DTPPCPSDK-2863
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!