update ci image to macOS 13 #318
Conversation
Reviewer's Guide by SourceryThis PR updates the CI configuration to use macOS 13 instead of macOS 12 for building the x86_64-apple-darwin target. This change is made in response to a GitHub Actions runner images update as referenced in the linked issue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe pull request modifies the GitHub Actions workflow configuration, specifically updating the macOS version for the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @satoren - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/release.yml (1)
41-44: Consider standardizing macOS versions across Apple targetsThere's an inconsistency in the macOS versions used:
- aarch64-apple-darwin uses macos-14
- x86_64-apple-darwin uses macos-13
Consider standardizing to use the same macOS version for both Apple targets to maintain consistency and simplify maintenance, unless there's a specific reason for using different versions.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 41-41: wrong indentation: expected 12 but found 14
(indentation)
[warning] 42-42: wrong indentation: expected 12 but found 14
(indentation)
[warning] 43-43: wrong indentation: expected 10 but found 12
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
44-44: Verify runner version compatibility
The change to macos-13 needs verification to ensure it's still a supported runner version.
✅ Verification successful
Based on the output, I can generate the final response as we have sufficient information about the macOS runner versions.
macOS 13 runner is fully supported
The verification confirms that macos-13 is an actively supported runner version:
- It's listed in the official runner images repository
- There are no open issues indicating deprecation or problems
- The version exists in both Intel (macos-13) and ARM (macos-13-arm64) variants
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if macos-13 is a supported runner version and check its deprecation status
# Fetch the latest runner versions from GitHub's API
gh api repos/actions/runner-images/contents/images/macos | jq -r '.[].name' | grep -E 'macos-[0-9]+' || echo "Failed to fetch runner versions"
# Check recent discussions about macos-13 support
gh api search/issues -X GET -f q="repo:actions/runner-images macos-13 label:OS" | jq -r '.items[] | select(.state == "open") | "Issue: \(.title)\nURL: \(.html_url)\n"'
Length of output: 423
actions/runner-images#10721
Summary by Sourcery
CI:
Summary by CodeRabbit