-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI update for variant cross-comparison #1948
base: master
Are you sure you want to change the base?
UI update for variant cross-comparison #1948
Conversation
This reverts commit 25be350.
...oops, I broke Group By and no one noticed so far
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sosiouxme The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
The final commit here adds on to #1937 trying to get a display of what you're looking at. I want to expand this to also reformat how it shows which component, capability, etc you're looking at, but at the moment I'm struggling to get it to match what the user requested. Sometimes the cross comparison variant seems to be dropped. Sometimes the dates don't get updated. I think my converting
useEffect
touseMemo
and trying to consolidate in central components means the hooks are not running quite when I want them to, but it's really confusing.