Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Only search for KUBE_SSH_BASTION when required #59999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Dec 18, 2024

rosa hcp does not have masters available to the client so this fails

rosa hcp does not have masters available to the client so this fails

Signed-off-by: Brady Pratt <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbpratt
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from dgoodwin and neisw December 18, 2024 13:06
@jbpratt jbpratt changed the title Only search for KUBE_SSH_BASTION when required NO-JIRA: Only search for KUBE_SSH_BASTION when required Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

@jbpratt: This pull request explicitly references no jira issue.

In response to this:

rosa hcp does not have masters available to the client so this fails

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jbpratt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-master-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-master-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.20-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.20-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.19-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.19-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.18-okd-scos-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.18-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.18-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.17-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.17-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.16-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.16-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.15-e2e-aws-ovn openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.15-e2e-aws-ovn-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-master-e2e-aws-serial openshift/api presubmit Registry content changed
pull-ci-openshift-api-master-e2e-aws-serial-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.20-e2e-aws-serial openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.20-e2e-aws-serial-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.19-e2e-aws-serial openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.19-e2e-aws-serial-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.18-e2e-aws-serial openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.18-e2e-aws-serial-techpreview openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.17-e2e-aws-serial openshift/api presubmit Registry content changed

A total of 12339 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jbpratt
Copy link
Contributor Author

jbpratt commented Dec 18, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jbpratt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants