Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Move oauth kubeadminsecret hash annotation logic from HCCO to CPO #5286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Dec 13, 2024

What this PR does / why we need it:
This avoids the conflict between HCCO and CPO reconciling the same deployment. All HCP components reconciliation should be done in the CPO

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2024
@openshift-ci-robot
Copy link

@muraee: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki December 13, 2024 14:20
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 13, 2024
@bryan-cox
Copy link
Member

Can you add the why/description to the commit? Otherwise lgtm.

@muraee
Copy link
Contributor Author

muraee commented Dec 14, 2024

/retest-required

@muraee muraee force-pushed the move-oauth-hash-cpo branch from 577fd43 to 0aa3dbe Compare December 16, 2024 10:08
This avoids the conflict between HCCO and CPO reconciling the same deployment. All HCP components reconciliation should be done in the CPO
@muraee muraee force-pushed the move-oauth-hash-cpo branch from 0aa3dbe to 4f62177 Compare December 16, 2024 10:09
@muraee
Copy link
Contributor Author

muraee commented Dec 16, 2024

/retest-required

3 similar comments
@muraee
Copy link
Contributor Author

muraee commented Dec 16, 2024

/retest-required

@muraee
Copy link
Contributor Author

muraee commented Dec 17, 2024

/retest-required

@muraee
Copy link
Contributor Author

muraee commented Dec 17, 2024

/retest-required

@muraee
Copy link
Contributor Author

muraee commented Dec 18, 2024

/override ci/prow/e2e-aws-override

@muraee
Copy link
Contributor Author

muraee commented Dec 18, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@muraee: Overrode contexts on behalf of muraee: ci/prow/e2e-aws-override

In response to this:

/override ci/prow/e2e-aws-override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@muraee
Copy link
Contributor Author

muraee commented Dec 19, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 30d9e69 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-override 30d9e69 link true /test e2e-aws-override

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants