OCPBUGS-46354: fix(ho): Add all supported config schemas for NodePool NTO reconcile #5280

hasueki · 2024-12-12T19:00:04Z

What this PR does / why we need it:
Fixes OCPBUGS-46354

Observed errors:

{"level":"error","ts":"2024-12-07T12:38:02Z","msg":"Failed to reconcile NodePool","controller":"nodepool","controllerGroup":"hypershift.openshift.io","controllerKind":"NodePool","NodePool":{"name":"30734861-mynodepool","namespace":"master"},"namespace":"master","name":"30734861-mynodepool","reconcileID":"a994e171-39d8-4ebe-b36d-d5bf3b32f91c","error":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","stacktrace":"github.com/openshift/hypershift/hypershift-operator/controllers/nodepool.(*NodePoolReconciler).Reconcile\n\t/hypershift/hypershift-operator/controllers/nodepool/nodepool_controller.go:205\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:222"}
{"level":"debug","ts":"2024-12-07T12:38:02Z","logger":"events","msg":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","type":"Warning","object":{"kind":"NodePool","namespace":"master","name":"30734861-mynodepool","uid":"6890952e-ffe4-4396-8df4-2054dd939a20","apiVersion":"hypershift.openshift.io/v1beta1","resourceVersion":"422964745"},"reason":"ReconcileError"}
{"level":"error","ts":"2024-12-07T12:38:03Z","msg":"Reconciler error","controller":"nodepool","controllerGroup":"hypershift.openshift.io","controllerKind":"NodePool","NodePool":{"name":"30734861-mynodepool","namespace":"master"},"namespace":"master","name":"30734861-mynodepool","reconcileID":"a994e171-39d8-4ebe-b36d-d5bf3b32f91c","error":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:324\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:222"}

Adding all API schemas based on:

hypershift/hypershift-operator/controllers/nodepool/config.go

Lines 263 to 266 in dc7bd65

    
           _ = mcfgv1.Install(scheme) 
        
           _ = v1alpha1.Install(scheme) 
        
           _ = configv1.Install(scheme) 
        
           _ = configv1alpha1.Install(scheme)

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-46354

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2024-12-12T19:00:10Z

@hasueki: This pull request references Jira Issue OCPBUGS-46354, which is invalid:

expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Fixes OCPBUGS-46354

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-46354

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hasueki · 2024-12-12T19:05:11Z

/jira refresh

openshift-ci-robot · 2024-12-12T19:05:19Z

@hasueki: This pull request references Jira Issue OCPBUGS-46354, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rtheis

/lgtm

rtheis · 2024-12-17T13:47:38Z

/retest-required

hasueki · 2024-12-17T19:07:09Z

/retest-required

enxebre · 2024-12-17T20:23:58Z

can we include a unit test for this func? it should be pretty similar to TestdefaultAndValidateConfigManifest

hypershift-operator/controllers/nodepool/nto.go

hasueki · 2024-12-18T20:25:06Z

can we include a unit test for this func? it should be pretty similar to TestdefaultAndValidateConfigManifest

@enxebre Unit test added

rtheis

/lgtm

rtheis · 2024-12-19T10:44:23Z

/retest-required

sjenning · 2024-12-19T14:49:34Z

/approve

openshift-ci · 2024-12-19T14:49:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasueki, rtheis, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sjenning · 2024-12-19T15:01:31Z

/test e2e-aks

openshift-ci-robot · 2024-12-19T19:08:50Z

/retest-required

Remaining retests: 0 against base HEAD 253fa18 and 2 for PR HEAD ad2f927 in total

openshift-ci-robot · 2024-12-20T00:08:51Z

/retest-required

Remaining retests: 0 against base HEAD 04b85e8 and 1 for PR HEAD ad2f927 in total

openshift-ci · 2024-12-20T04:14:00Z

@hasueki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-override	`f5ce417`	link	true	`/test e2e-aws-override`
ci/prow/okd-scos-e2e-aws-ovn	`ad2f927`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-12-20T04:27:09Z

/retest-required

Remaining retests: 0 against base HEAD 04b85e8 and 2 for PR HEAD ad2f927 in total

openshift-ci-robot · 2024-12-20T06:12:01Z

@hasueki: Jira Issue OCPBUGS-46354: All pull requests linked via external trackers have merged:

openshift/hypershift#5280

Jira Issue OCPBUGS-46354 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Fixes OCPBUGS-46354

Observed errors:

{"level":"error","ts":"2024-12-07T12:38:02Z","msg":"Failed to reconcile NodePool","controller":"nodepool","controllerGroup":"hypershift.openshift.io","controllerKind":"NodePool","NodePool":{"name":"30734861-mynodepool","namespace":"master"},"namespace":"master","name":"30734861-mynodepool","reconcileID":"a994e171-39d8-4ebe-b36d-d5bf3b32f91c","error":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","stacktrace":"github.com/openshift/hypershift/hypershift-operator/controllers/nodepool.(*NodePoolReconciler).Reconcile\n\t/hypershift/hypershift-operator/controllers/nodepool/nodepool_controller.go:205\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:222"}
{"level":"debug","ts":"2024-12-07T12:38:02Z","logger":"events","msg":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","type":"Warning","object":{"kind":"NodePool","namespace":"master","name":"30734861-mynodepool","uid":"6890952e-ffe4-4396-8df4-2054dd939a20","apiVersion":"hypershift.openshift.io/v1beta1","resourceVersion":"422964745"},"reason":"ReconcileError"}
{"level":"error","ts":"2024-12-07T12:38:03Z","msg":"Reconciler error","controller":"nodepool","controllerGroup":"hypershift.openshift.io","controllerKind":"NodePool","NodePool":{"name":"30734861-mynodepool","namespace":"master"},"namespace":"master","name":"30734861-mynodepool","reconcileID":"a994e171-39d8-4ebe-b36d-d5bf3b32f91c","error":"failed to reconcile NTO: failed to build mirror configs: configmap \"ignition-config-98-ibm-machineconfig-roks-30734861\" yaml document failed validation: error decoding config: no kind \"ImageDigestMirrorSet\" is registered for version \"config.openshift.io/v1\" in scheme \"/hypershift/hypershift-operator/controllers/nodepool/nto.go:415\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:324\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:222"}

Adding all API schemas based on:

hypershift/hypershift-operator/controllers/nodepool/config.go

Lines 263 to 266 in dc7bd65

    
           _ = mcfgv1.Install(scheme) 
        
           _ = v1alpha1.Install(scheme) 
        
           _ = configv1.Install(scheme) 
        
           _ = configv1alpha1.Install(scheme)

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-46354

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-12-20T08:44:41Z

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202412200739.p0.g5f05b35.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/needs-area label Dec 12, 2024

openshift-ci bot requested review from csrwng and enxebre December 12, 2024 19:00

openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Dec 12, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2024

rtheis approved these changes Dec 17, 2024

View reviewed changes

openshift-ci bot assigned rtheis Dec 17, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024

sjenning reviewed Dec 18, 2024

View reviewed changes

hypershift-operator/controllers/nodepool/nto.go Show resolved Hide resolved

fix(ho): Add all supported config schemas for NodePool NTO reconcile

ad2f927

hasueki force-pushed the fix-nto-reconcile branch from f5ce417 to ad2f927 Compare December 18, 2024 20:18

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

rtheis approved these changes Dec 19, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024

openshift-merge-bot bot merged commit 5f05b35 into openshift:main Dec 20, 2024
12 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-46354: fix(ho): Add all supported config schemas for NodePool NTO reconcile #5280

OCPBUGS-46354: fix(ho): Add all supported config schemas for NodePool NTO reconcile #5280

hasueki commented Dec 12, 2024 •

edited

Loading

openshift-ci-robot commented Dec 12, 2024

hasueki commented Dec 12, 2024

openshift-ci-robot commented Dec 12, 2024

rtheis left a comment

rtheis commented Dec 17, 2024

hasueki commented Dec 17, 2024

enxebre commented Dec 17, 2024

hasueki commented Dec 18, 2024

rtheis left a comment

rtheis commented Dec 19, 2024

sjenning commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

sjenning commented Dec 19, 2024

openshift-ci-robot commented Dec 19, 2024

openshift-ci-robot commented Dec 20, 2024

openshift-ci bot commented Dec 20, 2024 •

edited

Loading

openshift-ci-robot commented Dec 20, 2024

openshift-ci-robot commented Dec 20, 2024

openshift-bot commented Dec 20, 2024

	_ = mcfgv1.Install(scheme)
	_ = v1alpha1.Install(scheme)
	_ = configv1.Install(scheme)
	_ = configv1alpha1.Install(scheme)

OCPBUGS-46354: fix(ho): Add all supported config schemas for NodePool NTO reconcile #5280

OCPBUGS-46354: fix(ho): Add all supported config schemas for NodePool NTO reconcile #5280

Conversation

hasueki commented Dec 12, 2024 • edited Loading

openshift-ci-robot commented Dec 12, 2024

hasueki commented Dec 12, 2024

openshift-ci-robot commented Dec 12, 2024

rtheis left a comment

Choose a reason for hiding this comment

rtheis commented Dec 17, 2024

hasueki commented Dec 17, 2024

enxebre commented Dec 17, 2024

hasueki commented Dec 18, 2024

rtheis left a comment

Choose a reason for hiding this comment

rtheis commented Dec 19, 2024

sjenning commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

sjenning commented Dec 19, 2024

openshift-ci-robot commented Dec 19, 2024

openshift-ci-robot commented Dec 20, 2024

openshift-ci bot commented Dec 20, 2024 • edited Loading

openshift-ci-robot commented Dec 20, 2024

openshift-ci-robot commented Dec 20, 2024

openshift-bot commented Dec 20, 2024

hasueki commented Dec 12, 2024 •

edited

Loading

openshift-ci bot commented Dec 20, 2024 •

edited

Loading