Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-45864: Create AWS clients on every reconcile instead of at initialization #5246

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-45864: Create AWS clients on every reconcile instead of at initialization #5246

wants to merge 1 commit into from
+167 −62

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5201

/assign csrwng

@csrwng
Create AWS clients on every reconcile instead of at initialization
fbf6a92 
Moves client creation for the private link endpoint controller into the
reconcile loop instead of when the reconciler is initially registered.
This allows the controller to recover from initial issues assuming a
shared vpc role.

Adds additional error logging when AWS cloud API calls fail.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 7, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-45184 has been cloned as Jira Issue OCPBUGS-45864. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-45864: Create AWS clients on every reconcile instead of at initialization

In response to this:

This is an automated cherry-pick of #5201

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-45184: Create AWS clients on every reconcile instead of at initialization [release-4.17] OCPBUGS-45864: Create AWS clients on every reconcile instead of at initialization Dec 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45864, which is invalid:

  • expected dependent Jira Issue OCPBUGS-45184 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #5201

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre December 7, 2024 01:40
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from csrwng. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws fbf6a92 link true /test e2e-aws
ci/prow/mce-images fbf6a92 link true /test mce-images
ci/prow/e2e-kubevirt-aws-ovn-reduced fbf6a92 link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/images fbf6a92 link true /test images
ci/prow/verify fbf6a92 link true /test verify
ci/prow/unit fbf6a92 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@csrwng
Copy link
Contributor

csrwng commented Dec 18, 2024

/jira refresh

@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-45864, which is invalid:

  • expected dependent Jira Issue OCPBUGS-45184 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @csrwng