Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofParameterGroup::add(std::shared_ptr<ofAbstractParameter> param); #8127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

artificiel
Copy link
Contributor

ofParameterGroup::add() takes a reference to add a parameter, but internally manages a container of shared_ptr.

As discussed here https://forum.openframeworks.cc/t/ofparametergroup-add-with-a-local-ofparameter/43666 sometimes one already has hold of a shared_ptr pointing to a param, and would want to pass it to a group. or someone want to create a parameter and have the group being the sole container for it.

This implements ofParameterGroup::add(std::shared_ptr param) (which, incidentally, is everything but the first line of the original ofParameterGroup::add(ofAbstractParameter & param)

So it is now possible to do:

group.add(std::make_shared<ofParameter<float>>("f",2));

and the group holds onto the shared_ptr. of course this is a pretty specific application (where you will have to go through the group to get to the parameter).

@ofTheo
Copy link
Member

ofTheo commented Oct 16, 2024

think this is fine to merge once the conflicts are resolved

@artificiel artificiel marked this pull request as draft October 22, 2024 00:50
@artificiel artificiel marked this pull request as ready for review November 8, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants